Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update JP ver. of README #421

Merged
merged 2 commits into from
Apr 10, 2023
Merged

chore: update JP ver. of README #421

merged 2 commits into from
Apr 10, 2023

Conversation

poppoerika
Copy link
Contributor

No description provided.

pgautier404
pgautier404 reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this and the main templated README are both still referring to SimpleCacheClient instead of CacheClient. Would you mind fixing that in this file at least and maybe opening an issue to take a closer look at the main README as well?

pgautier404
pgautier404 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@poppoerika poppoerika merged commit 5447d65 into main Apr 10, 2023
@poppoerika poppoerika deleted the chore/update-jp-readme branch April 10, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgautier404 pgautier404 pgautier404 approved these changes

@cprice404 cprice404 Awaiting requested review from cprice404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poppoerika @pgautier404