feat: support .NET Framework 4.61+ using gRPC-Web #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malandis
force-pushed
the
feat/support-net-framework-461
branch
from
ef8ecac
to
4e1b2ad
Compare
We already test in build and merge to main branch.
Test on net461 on windows, otherwise use linux.
|
Opening for review. I will build a test app and manually run on Windows Server 2016. |
cprice404
reviewed
Apr 26, 2023
Because .NET Framework does not support gRPC over HTTP/2, we fall back to using gRPC for those older versions. To do this we: 1. Add another target framework for the library, `net461`. This is the lowest .NET Framework version also supported by `netstandard2.0`. 2. Conditional on a `net461` build, link the gRPC-Web client dependency. 3. Conditional on a `net461` build, use a gRPC-Web `HttpHandler` for the control and data gRPC channels. 4. Update the test projects to exercise the `net461` build as well.
cprice404
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because .NET Framework does not support gRPC over HTTP/2, we fall back
to using gRPC for those older versions. To do this we:
Add another target framework for the library,
net461. This is thelowest .NET Framework version also supported by
netstandard2.0.Conditional on a
net461build, link the gRPC-Web clientdependency.
Conditional on a
net461build, use a gRPC-WebHttpHandlerforthe control and data gRPC channels.
Update the test projects to exercise the
net461build as well.closes: https://github.com/momentohq/dev-eco-issue-tracker/issues/317