feat: add lambda configuration #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a configuration optimized for Lambda environments. This is the same as the `InRegion.LowLatency` config but also eagerly connects the client. This avoids the cold start penalty from before where we established the connection on the first request, leading to first-request timeouts.
cprice404
reviewed
Apr 26, 2023
| /// <returns></returns> | ||
| public static IConfiguration Latest(ILoggerFactory? loggerFactory = null) | ||
| { | ||
| var config = LowLatency.V1(loggerFactory); |
There was a problem hiding this comment.
I think maybe you should go with InRegion.Default rather than InRegion.LowLatency. I don't think lambdas are guaranteed to have great networking traits so making the timeout a tiny bit more lenient is probably the way to go.
Sorry for not mentioning sooner.
@eaddingtonwhite can you weigh in on this?
There was a problem hiding this comment.
I changed this to InRegion.Default here
There was a problem hiding this comment.
Agree w/ this. Start more conservative w/ default timeouts we can always make more agressive down line.
There was a problem hiding this comment.
OK. In that case b164b6a implements this.
eaddingtonwhite
approved these changes
Apr 26, 2023
cprice404
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration optimized for Lambda environments. This is the
same as the
InRegion.Defaultconfig but also eagerly connects theclient. This avoids the cold start penalty from before where we
established the connection on the first request, leading to
first-request timeouts.