Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Dictionary Length API #448

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

rishtigupta
Copy link
Contributor

PR Description:

Add support for Dictionary Length API

Testing

  • Integration tests:
    • TEST_CACHE_NAME="test-cache" dotnet test -f net6.0 --filter "DictionaryLengthAsync_HappyPath"
    • TEST_CACHE_NAME="test-cache" dotnet test -f net6.0 --filter "DictionaryLengthAsync_DictionaryIsMissing"

Issue

closes #447

@rishtigupta rishtigupta marked this pull request as ready for review June 5, 2023 22:35
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Just a couple typos. Also, since this command is retryable, would you add an entry in DefaultRetryEligibilityStrategy.cs for this?

src/Momento.Sdk/ICacheClient.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/Responses/CacheDictionaryLengthResponse.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/Responses/CacheDictionaryLengthResponse.cs Outdated Show resolved Hide resolved
@rishtigupta rishtigupta requested a review from malandis June 5, 2023 23:04
@rishtigupta rishtigupta merged commit 076faff into main Jun 6, 2023
@rishtigupta rishtigupta deleted the feat/add-dictionary-length branch June 6, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add DictionaryLength
2 participants