feat: add auth client #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
add-auth-client
branch
from
12616cd
to
7b9d73b
Compare
anitarua
reviewed
Sep 8, 2023
cprice404
reviewed
Sep 8, 2023
src/Momento.Sdk/Auth/Utils.cs
Outdated
| @@ -65,6 +68,9 @@ public static TokenAndEndpoints TryDecodeAuthToken(string authToken) | |||
| return new TokenAndEndpoints( | |||
| authToken, | |||
| claims.ControlEndpoint, | |||
| claims.CacheEndpoint, | |||
| // TODO: assuming legacy tokens will never have a token endpoint. AFAIK, they can't be used | |||
| // to generate disposable tokens anyway, but verify and see if this needs to be fixed. | |||
| @@ -17,6 +17,8 @@ public class StringMomentoTokenProvider : ICredentialProvider | |||
| public string ControlEndpoint { get; private set; } | |||
| /// <inheritdoc /> | |||
| public string CacheEndpoint { get; private set; } | |||
| /// <inheritdoc /> | |||
| public string TokenEndpoint { get; private set; } | |||
There was a problem hiding this comment.
Good catch, thanks. It gets set in b75af12 :-)
cprice404
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an auth client that is currently solely responsible for generating disposable tokens.