Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement mvi get item and get item metadata methods #522

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Dec 8, 2023

Implements MVI GetItemBatchAsync and GetItemMetadataBatchAsync methods, response types, and adds integration tests. Also extracts metadata dictionary equality and hash code to a central extension method.

@malandis malandis marked this pull request as ready for review December 8, 2023 20:51
bruuuuuuuce
bruuuuuuuce previously approved these changes Dec 8, 2023
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

nand4011
nand4011 previously approved these changes Dec 8, 2023
Copy link
Contributor

@nand4011 nand4011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of doc nits, but LGTM.

src/Momento.Sdk/IPreviewVectorIndexClient.cs Outdated Show resolved Hide resolved
@malandis malandis dismissed stale reviews from nand4011 and bruuuuuuuce via b2a14e9 December 8, 2023 23:12
Previously we had mistakenly called "item metadata" items.

Co-authored-by: Nate Anderson <[email protected]>
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@malandis malandis merged commit 1e74b81 into main Dec 8, 2023
7 checks passed
@malandis malandis deleted the feat/mvi-get-item-and-get-item-metadata branch December 8, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants