Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add grpc config options and turn off keepalive for Lambda config" #538

Merged
merged 18 commits into from
Mar 4, 2024
Merged

feat: add grpc config options and turn off keepalive for Lambda config" #538

merged 18 commits into from
Mar 4, 2024

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Feb 28, 2024 •
edited
Loading

DRYs up the grpc channel options setting into a single function called by the various grpc managers.
Adds keepalive settings to all prebuilt configs with a StaticGrpcConfiguration specified except for Lambda, which should not have keepalives turned on.

@anitarua anitarua marked this pull request as ready for review February 29, 2024 21:51
nand4011
nand4011 reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nand4011 nand4011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! The repeated grpc code has been bugging me for a while. I have a question about organization, but LGTM otherwise.

src/Momento.Sdk/Internal/Utils.cs Outdated Show resolved Hide resolved
cprice404
cprice404 reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks! i had a few suggestions, and after you take another pass we should definitely get @malandis to sign off on this before it goes in :)

src/Momento.Sdk/Config/TopicConfigurations.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/Config/Transport/IGrpcConfiguration.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/Config/Transport/IGrpcConfiguration.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/Config/Transport/IGrpcConfiguration.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/Config/Transport/StaticTransportStrategy.cs Show resolved Hide resolved
src/Momento.Sdk/Config/Transport/StaticTransportStrategy.cs Outdated Show resolved Hide resolved
src/Momento.Sdk/PreviewVectorIndexClient.cs Show resolved Hide resolved
@anitarua anitarua requested a review from cprice404 March 2, 2024 01:16
@anitarua anitarua requested a review from malandis March 4, 2024 17:31
@anitarua anitarua mentioned this pull request Mar 4, 2024
Closed
@anitarua anitarua merged commit 4db09f8 into main Mar 4, 2024
7 checks passed
@anitarua anitarua deleted the grpc-configs branch March 4, 2024 22:56
@anitarua anitarua mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nand4011 nand4011 nand4011 left review comments

@malandis malandis malandis approved these changes

@pgautier404 pgautier404 Awaiting requested review from pgautier404

@cprice404 cprice404 Awaiting requested review from cprice404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anitarua @nand4011 @cprice404 @malandis