Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop grpc-web for .NET 4.62 build. #543

Merged
merged 6 commits into from
Mar 6, 2024
Merged

feat: drop grpc-web for .NET 4.62 build. #543

merged 6 commits into from
Mar 6, 2024

Commits on Mar 6, 2024

  1. feat: drop grpc-web for .NET 4.62 build. 

    Since we bumped the minimum .NET Framework build version from 4.61 to
4.62, we gained access to an Http/2 handler for .NET
Framework. Because 4.61 did not have an Http/2 handler, we had to
resort to gRPC-Web. Now we only need gRPC-Web for the Unity build.

In order to exercise the gRPC-Web build, we add that to the testing
matrix.
    @malandis
    malandis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6be644e View commit details
    Browse the repository at this point in the history

  2. chore: evaluate matrix.grpc-web in boolean context

    @malandis
    malandis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d628a14 View commit details
    Browse the repository at this point in the history

  3. refactor: factor out common elements of test matrix 

    The only extra entry to add to the test matrix is running net462 on
windows.
    @malandis
    malandis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    281cdaa View commit details
    Browse the repository at this point in the history

  4. fix: target framework needs to be in a list for the matrix

    @malandis
    malandis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    21c6394 View commit details
    Browse the repository at this point in the history

  5. fix: windows/net462 needs to run with and without grpc-web

    @malandis
    malandis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cd90fe1 View commit details
    Browse the repository at this point in the history

  6. fix: github actions include doesn't expand existing options

    @malandis
    malandis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0d34d45 View commit details
    Browse the repository at this point in the history