Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly re-throw caught exception in eager connection code #550

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix: properly re-throw caught exception in eager connection code #550

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c07f7f5
fix: properly re-throw caught exception in eager connection code
malandis Mar 15, 2024
307cf63
chore: remove unused exception name
malandis Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Momento.Sdk/CacheClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@
{
await cacheClient.DataClient.EagerConnectAsync(eagerConnectionTimeout);
}
catch (Exception e)

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (windows-latest, net6.0, false) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (windows-latest, net6.0, true) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (ubuntu-latest, net6.0, true) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (ubuntu-latest, net6.0, true) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (windows-latest, net462, false) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (windows-latest, net462, true) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (windows-latest, net462, true) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (ubuntu-latest, net6.0, false) 

The variable 'e' is declared but never used

Check warning on line 58 in src/Momento.Sdk/CacheClient.cs

View workflow job for this annotation

GitHub Actions / build_csharp (ubuntu-latest, net6.0, false) 

The variable 'e' is declared but never used
{
cacheClient.Dispose();
throw e;
throw;
}
return cacheClient;
}
Expand Down
Loading