Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onetime headers for agent and runtime-version #558

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

bruuuuuuuce
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce commented Jun 12, 2024

agent: dotnet:1.0.0.0, runtime-version: .NET 6.0.11

The agent is showing up as 1.0.0.0 because inside of our sdk .csproj we do not have a Version property. This property gets set when we actually cut the release. I manually set the .csproj Version property to 2.2.2 and the agent shows up as dotnet:2.2.2.0

closes https://github.com/momentohq/dev-eco-issue-tracker/issues/887

@bruuuuuuuce bruuuuuuuce marked this pull request as ready for review June 12, 2024 18:43
@bruuuuuuuce bruuuuuuuce requested a review from a team June 12, 2024 18:43
Copy link
Contributor

@anitarua anitarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cprice404 cprice404 self-requested a review June 13, 2024 23:07
@bruuuuuuuce bruuuuuuuce merged commit c0541e6 into main Jun 13, 2024
10 checks passed
@bruuuuuuuce bruuuuuuuce deleted the feat/onetimeHeaders branch June 13, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants