feat: Add a separate web SDK for clients without HTTP 2.0 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new Momento.Sdk.Web artifact that uses gRPC-Web so that users without access to HTTP 2.0 can use the SDK. Building with the USE_GRPC_WEB will generate the new Momento.Sdk.Web.dll. Note that this will affect the unity build as well. Add a pack and publish step to push the new artifact to nuget.
nand4011
commented
Sep 5, 2024
| echo "version: ${VERSION}" | ||
| dotnet build -p:DefineConstants=USE_GRPC_WEB --configuration Release | ||
| dotnet pack -p:DefineConstants=USE_GRPC_WEB -c Release -p:Version=${VERSION} | ||
| # dotnet nuget push ./bin/Release/Momento.Sdk.Web.${VERSION}.nupkg --source https://api.nuget.org/v3/index.json --api-key=${{secrets.NUGET_API_KEY}} |
There was a problem hiding this comment.
I've executed the steps up to here locally. Do we have a good place to publish this temporarily to test that it works?
There was a problem hiding this comment.
no, but since it's a net new package, no one will have deps on it yet, so it's not the end of the world if it's broken as long as we fast follow any necessary fixes.
|
We should follow this with an addition to the examples that uses the new web SDK dependency. |
cprice404
previously approved these changes
Sep 6, 2024
| @@ -68,7 +79,7 @@ jobs: | |||
| dotnet publish --configuration Release -f netstandard2.0 -p:DefineConstants=USE_GRPC_WEB -p:VersionPrefix=${VERSION} | |||
| mkdir ./bin/Release/netstandard2.0/MomentoSdkUnity | |||
| pushd ./bin/Release/netstandard2.0/publish/ | |||
| cp Google.Protobuf.dll Grpc.Core.Api.dll Grpc.Net.Client.dll Grpc.Net.Client.Web.dll Grpc.Net.Common.dll JWT.dll Microsoft.Bcl.AsyncInterfaces.dll Microsoft.Extensions.Logging.Abstractions.dll Momento.Protos.dll Momento.Sdk.dll Newtonsoft.Json.dll System.Diagnostics.DiagnosticSource.dll System.Runtime.CompilerServices.Unsafe.dll System.Threading.Channels.dll ../MomentoSdkUnity/ | |||
| cp Google.Protobuf.dll Grpc.Core.Api.dll Grpc.Net.Client.dll Grpc.Net.Client.Web.dll Grpc.Net.Common.dll JWT.dll Microsoft.Bcl.AsyncInterfaces.dll Microsoft.Extensions.Logging.Abstractions.dll Momento.Protos.dll Momento.Sdk.Web.dll Newtonsoft.Json.dll System.Diagnostics.DiagnosticSource.dll System.Runtime.CompilerServices.Unsafe.dll System.Threading.Channels.dll ../MomentoSdkUnity/ | |||
There was a problem hiding this comment.
we might need to update the unity demo docs after this goes in
Remove redundant build step. Add comments above the standard and web SDK property groups.
malandis
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Momento.Sdk.Web artifact that uses gRPC-Web so that users without access to HTTP 2.0 can use the SDK. Building with the USE_GRPC_WEB will generate the new Momento.Sdk.Web.dll. Note that this will affect the unity build as well.
Add a pack and publish step to push the new artifact to nuget.