feat: add pubsub #353
Merged
feat: add pubsub #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
add-pubsub
branch
2 times, most recently
from
54c2cb8
to
5026b9d
Compare
pgautier404
force-pushed
the
add-pubsub
branch
5 times, most recently
from
2612c05
to
297c450
Compare
pgautier404
force-pushed
the
add-pubsub
branch
2 times, most recently
from
e2210cb
to
96c0c80
Compare
malandis
reviewed
Jul 13, 2023
| request = pubsub_pb._SubscriptionRequest( | ||
| cache_name=cache_name, | ||
| topic=topic_name, | ||
| # TODO: resume_at_topic_sequence_number |
| request = pubsub_pb._SubscriptionRequest( | ||
| cache_name=cache_name, | ||
| topic=topic_name, | ||
| # TODO: resume_at_topic_sequence_number |
Excellent suggestion, thanks! |
malandis
reviewed
Jul 13, 2023
malandis
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds pubsub capabilities to the Python SDK via the TopicClient. It also corrects the usage of the
@behaves_likedecorator throughout the test code, which had been preventing a large number of tests from ever executing.