feat: adding basic example for MVI #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the vector index responses are under a namespace, we can remove the "VectorIndex" prefix.
Because the vector index client is not 1.0, we use the prefix "Preview" to distinguish it from the production clients.
To leave the CI/CD alone, we will disable running vector index client tests until that service is live.
For clarity's sake indicate the client is the vector index data client.
Previously we comingled the vector index control client with the cache client code. This is because the vector index commands reside on the cache control service. Unfortunately, because the vector index service and cache service have different configuration needs, and the control client takes as input a cache configuration object, we need to separate these out. The upshot is this adds clarity to the project. The vector index grpc related clients can be found in: _vector_index_grpc_manager, _vector_index_data_client, and _vector_index_control_client. The files contain only those commands relevant to the vector index service.
Previously the pre-built `VectorIndexConfigurations` returned a `Configuration`, ie a cache client configuration. Here we add a parallel set of configurations just for the vector index client. That way the vector index configuration doesn't have potentially unnecessary configuration options.
For v0 we will provide `add_item_batch` which performs an insert. The insert may add an entry with the same ID as an existing entry.
We introduce a data API to delete a batch of items by ID. The API accepts a list of ids (as string), and removes any and all occurrences of items matching those ids.
malandis
reviewed
Aug 25, 2023
|
Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic example for MVI to create index, list them, add items, search for them, and finally delete the index.