Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use vector endpoint for MVI API calls #373

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

pratik151192
Copy link
Contributor

@pratik151192 pratik151192 commented Aug 28, 2023

For MVI data plane calls, we were using cache as the endpoint prefix; this PR updates it to use vector. Note that for legacy tokens, we do not have a new JWT claim, so we will be using cache as the prefix for that as well.

Also, for control plane operations, the endpoint prefix is still control.

_CONTROL_ENDPOINT_CLAIM_ID = "cp"
_CACHE_ENDPOINT_CLAIM_ID = "c"
_VECTOR_ENDPOINT_CLAIM_ID = "c"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont have a new claim here so defaulting to c

@pratik151192 pratik151192 marked this pull request as ready for review August 28, 2023 17:50
Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @cprice404 ?

Copy link
Collaborator

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

@pratik151192 pratik151192 merged commit 6f6e0f8 into main Aug 28, 2023
20 checks passed
@pratik151192 pratik151192 deleted the use-vector-endpoint branch August 28, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants