refactor: rename mvi parameter ids to filter on get/delete items
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruuuuuuuce
reviewed
Feb 12, 2024
| @@ -107,7 +107,7 @@ def search(client: PreviewVectorIndexClient, index_name: str) -> None: | |||
| def delete_items(client: PreviewVectorIndexClient, index_name: str) -> None: | |||
| item_ids_to_delete = ["test_item_1", "test_item_3"] | |||
| _logger.info(f"Deleting items: {item_ids_to_delete}") | |||
| delete_response = client.delete_item_batch(index_name, ids=item_ids_to_delete) | |||
| delete_response = client.delete_item_batch(index_name, filter=item_ids_to_delete) | |||
There was a problem hiding this comment.
just wondering, why filter and not filters? Looks like this is an array
There was a problem hiding this comment.
In a coming PR this will accept a (single) filter expression or (for convenience) a list of ids to select.
bruuuuuuuce
reviewed
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To standardize how we select items in
get item batch,get item metadata batch, anddelete item batch, we use the termfilterin methods, whether selecting by ids or filter expression.