-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not use test util in package #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here, the validators are best placed alongside the ones here |
Lastly could you roll up the names from the utilities to the utilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need the init file for utilities
that rolls up names from the various modules therein.
Ran into an error while writing new dev docs examples. Created a new
str_to_bytes
util function in the package proper rather than using the one fromtests.utils
. Bug appears to be fixed when running the examples against a locally built version of the package now.Also moved the two validators to internal utils where the others are.