Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to create pre-signed URLs #78

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

virratanasangpunth
Copy link
Contributor

No description provided.

@virratanasangpunth virratanasangpunth marked this pull request as draft April 7, 2022 21:33
@virratanasangpunth virratanasangpunth marked this pull request as ready for review April 7, 2022 22:03
Copy link
Contributor

@kvcache kvcache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Got a couple things to consider

src/momento/momento_signer.py Outdated Show resolved Hide resolved
src/momento/momento_signer.py Outdated Show resolved Hide resolved
src/momento/momento_signer.py Outdated Show resolved Hide resolved
src/momento/momento_signer.py Show resolved Hide resolved
src/momento/momento_signer.py Outdated Show resolved Hide resolved
src/momento/momento_signer.py Outdated Show resolved Hide resolved
src/momento/momento_signer.py Outdated Show resolved Hide resolved
Copy link

@wandaitzuchen wandaitzuchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@virratanasangpunth virratanasangpunth merged commit 262ac0f into main Apr 11, 2022
@virratanasangpunth virratanasangpunth deleted the vir/sign branch April 11, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants