fix: use heuristics to determine when to query ddb table ttl #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruuuuuuuce
requested review from
nand4011,
cprice404,
pgautier404 and
rishtigupta
cprice404
reviewed
Apr 11, 2024
| let mut resources = get_ddb_resources(&config, Arc::clone(&limiter)).await?; | ||
| let metrics_quota = | ||
| Quota::per_second(core::num::NonZeroU32::new(20).expect("should create non-zero quota")); | ||
| let metrics_limiter = Arc::new(RateLimiter::direct(metrics_quota)); |
cprice404
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The describe_time_to_live api call is heavily throttled, we don't want to have to call it for every dynamodb table. This pr separates out the describe ttl call into a separate function, and only calls it on tables who have at least an average of 100tps over the course of a month. We can tune this heuristic later on
Before
After
