feat: add the unlink command #4
Conversation
| var deleteFutures = | ||
| Arrays.stream(ks) | ||
| .map(k -> client.delete(cacheName, codec.encodeKeyToBytes(k))) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
Because many Redis commands are variadic and batch oriented, we need to fan out to Momento.
There was a problem hiding this comment.
this will have thread pool implications. We should extract this type of logic to a common helper function that we channel all of these types of batching operations through, so that we can add more explicit concurrency controls to it in the future if we need to. We don't need to solve the concurrency issues as part of this initial spike though.
There was a problem hiding this comment.
@nand4011 we may wanna pull you into this re: concurrency stuff at some point. For now I'd just like to abstract it to a single place so we can easily change the behavior later but if any specific concurrency issues come up your recent experience in the java sdk repo will be relevant.
| var deleteFutures = | ||
| Arrays.stream(ks) | ||
| .map(k -> client.delete(cacheName, codec.encodeKeyToBytes(k))) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
this will have thread pool implications. We should extract this type of logic to a common helper function that we channel all of these types of batching operations through, so that we can add more explicit concurrency controls to it in the future if we need to. We don't need to solve the concurrency issues as part of this initial spike though.
Unlink is a Redis command similar to delete.
|
I rebased so no changes @cprice404 . @rishtigupta or @nand4011 any comments about the future concurrency work? |
You don't need to do it in this PR but before you perpetuate that |
Adds the Lettuce
unlinkcommand, which is similar todelete. Because the command takes variadic arguments, we fan out the delete requests. In the future we can hook up our rate limiting to this section.