feat: initial impl of momento keyv #1
Conversation
eaddingtonwhite
requested review from
cprice404,
malandis,
pratik151192 and
bruuuuuuuce
There was a problem hiding this comment.
would love to add an int test layer that validates our behavior vs some other backend using a docker container, but not a blocker for this PR.
@malandis should look at this too but I am okay with you merging and he can weigh in after if you have someone you're trying to share this with.
|
|
||
| ## Usage | ||
|
|
||
| ```ts |
There was a problem hiding this comment.
FYI with the new v2 template engine you can just use an include tag to pull in as many code files as you want:
https://github.com/momentohq/client-sdk-javascript/blob/main/README.template.md?plain=1#L16
not a blocker for this pr but just letting you know, that way we can make sure ci runs the code
There was a problem hiding this comment.
Ill do in follow up PR good call!
|
@cprice404 this is more of adapter specifically for momento for keyv vs wrapper around redis so I dont think having integration test w/ different backends makes as much sense for this lib. Also have no way to configure a redis run mode for this version of adapator they would just use redis-adapter directly. |
No description provided.