Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ts-starter #9] create bootstrap #13

Open
wants to merge 2 commits into
base: feat/bundle-size-analysis
Choose a base branch
from

Conversation

ehsanmmd
Copy link
Contributor

@ehsanmmd ehsanmmd commented Mar 21, 2024

No description provided.

@ehsanmmd ehsanmmd requested a review from momesana March 21, 2024 11:14
@ehsanmmd ehsanmmd self-assigned this Mar 21, 2024
@ehsanmmd ehsanmmd changed the title Feat/create bootstrap WIP: Feat/create bootstrap Mar 21, 2024
@ehsanmmd ehsanmmd changed the base branch from main to feat/bundle-size-analysis March 21, 2024 15:06
@ehsanmmd ehsanmmd force-pushed the feat/bundle-size-analysis branch 2 times, most recently from 293dfa2 to 3c40bce Compare March 23, 2024 07:42
@ehsanmmd ehsanmmd changed the title WIP: Feat/create bootstrap Feat/create bootstrap Mar 23, 2024
@ehsanmmd ehsanmmd changed the title Feat/create bootstrap feat: [ts-starter #9] create bootstrap Mar 23, 2024
src/index.tsx Outdated

export default function Index(): ReactElement {
return (
<ErrorBoundary fallback={<div>shit hit the fan bruv!</div>}>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the hell? That doesn't belong there. Use a simple component that shows the error message. That should take more than 15 minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants