feat(TransitionView): component to be used on wizard-related logics to render a step with animation between steps #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to render a step with animation between steps
|
@shaharzil @talkor I'm not a big favor of the name I gave to that component, but I think using just Wizard here is too confusing, as it is only responsible on rendering a single child with animation among given children. it does not do any other logic related to Wizard in general |
talkor
approved these changes
Oct 30, 2024
packages/core/src/components/WizardSlideshow/__tests__/WizardSlideshow.test.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/WizardSlideshow/WizardSlideshow.tsx
Outdated
Show resolved
Hide resolved
…ponent-to-handle-animation-and-render-of-7525075588
YossiSaadi
changed the title
YossiSaadi
deleted the
feat/yossi/wizard-a-generic-component-to-handle-animation-and-render-of-7525075588
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WizardSlideshow result:
Original design request:
Note: name was changed from
WizardSlideshowtoTransitionViewhttps://monday.monday.com/boards/3532714909/pulses/7525075588