Fix bugs on allow multiple on click #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadasfa
commented
Dec 14, 2021
| @@ -33,9 +33,12 @@ const Accordion = forwardRef(({ children: originalChildren, allowMultiple, defau | |||
| const onChildClick = useCallback( | |||
| itemIndex => { | |||
| if (allowMultiple) { | |||
| const newExpandedItems = expandedItems; | |||
| const newExpandedItems = [...expandedItems]; | |||
There was a problem hiding this comment.
the first bug was that changing the state does not cause a render because the state was mutable
hadasfa
commented
Dec 14, 2021
| newExpandedItems.pop(itemIndex); | ||
| const index = newExpandedItems.indexOf(itemIndex); | ||
| if (index > -1) { | ||
| newExpandedItems.splice(index, 1); |
There was a problem hiding this comment.
the second bug was that clicking on already selected drawer caused removing the last opened drawer instead of the one we click on.
MosheZemah
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the allow multiple functionality was buggy because the on click functionality was not working as excepted