Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown - add isOptionSelected prop #532

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Dropdown - add isOptionSelected prop #532

merged 1 commit into from
Feb 15, 2022

Conversation

RonNachmany
Copy link
Contributor

@RonNachmany RonNachmany commented Feb 14, 2022 •
edited
Loading

Dropdown - add isOptionSelected prop

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@RonNachmany RonNachmany self-assigned this Feb 14, 2022
@RonNachmany RonNachmany added enhancement New feature or request feature and removed enhancement New feature or request labels Feb 15, 2022
@RonNachmany RonNachmany merged commit 962d968 into master Feb 15, 2022
@RonNachmany RonNachmany deleted the add-is-option-seleted-to-dropdown branch February 15, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mentaman mentaman mentaman approved these changes

Assignees

@RonNachmany RonNachmany

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonNachmany @mentaman