Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add support for Linux arm64 docker builds #3924

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

redsh4de
Copy link

@redsh4de redsh4de commented May 17, 2022

Modifies Dockerfile.linux and Makefile to allow users to compile static arm64 linux builds.

For arm64 builds, an extra optional argument --build--arg UBUNTU_VERSION=18.04 will need to be added to the docker build command. Running make with docker run, release-static would have to be changed to release-static-linux-armv8.

Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add instructions to readme?

@redsh4de
Copy link
Author

Updated :)

@selsta
Copy link
Collaborator

selsta commented May 19, 2022

Thanks, do you know how to squash your commits?

@redsh4de
Copy link
Author

Haven't done it before, would git rebase -i HEAD~4 be the way to go about it in our case?

@selsta
Copy link
Collaborator

selsta commented May 19, 2022

I usually do:

git rebase -i origin/master

and then I set the commits that I want to squash to s.

Edit: what you wrote should work too, I just noticed that you are in master branch so what I wrote doesn't apply.

@redsh4de
Copy link
Author

redsh4de commented May 19, 2022

That takes care of that :D

@selsta
Copy link
Collaborator

selsta commented May 19, 2022

@zer0conf something went wrong

Update README.md

Added Docker instructions for static Linux arm64 builds

relaunch check

Update Makefile

/bin/sh compatbility
@redsh4de
Copy link
Author

Fixed, the squash reached a bit too far back

@selsta
Copy link
Collaborator

selsta commented Jul 14, 2022

Some unintended commits got added again, I think the issue is that you opened this from master branch. Will try to get this merged after the v0.18 release.

@redsh4de
Copy link
Author

Checked why docker-linux-static failed, stems from an error while cloning m4:
fatal: Could not parse object 'f662e3a93ebdec3d1c9374382dcc070093a42fed'.

@selsta
Copy link
Collaborator

selsta commented Jul 14, 2022

yea i fixed it here #3969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants