add note about get_transfers/get_transfer_by_txid destinations being undefined, make it more consistent
#2306
Conversation
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
recanman
changed the title
get_transfers/get_transfer_by_txid destinations being undefinedget_transfers/get_transfer_by_txid destinations being undefined, make it more consistent
|
squash? |
…undefined, make it more consistent
|
@HardenedSteel squashed |
|
would it not be better to just add a "Note: ..." next to the destinations* param? the scary warning for unlock time was an exception, unless this is of the same severity if overlooked? |
| @@ -1984,6 +1985,7 @@ $ curl http://127.0.0.1:18082/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"g | |||
| Show information about a transfer to/from this address. | |||
|
|
|||
| <p style="color:red;"><b>WARNING</b> Verify that the transfer has a sane <code>unlock_time</code> otherwise the funds might be inaccessible.</p> | |||
| <p style="color:red;"><b>WARNING</b> <code>destinations</code>, only available for outgoing transactions, will be <b>UNDEFINED</b> if not in the wallet cache.</p> | |||
There was a problem hiding this comment.
Kind of a nitpick, but it would be nice if this message matched the one above.
I think it's worthy of a warning, since you can permanently lose accounting information, which I remember caused at least one person financial damage since they couldn't provide a valid tx spend proof to their exchange. |
|
with the new docs site we can play around with warnings.
the possible repercussions of deleting the wallet cache / re-syncing a wallet would fill the entire doc with red warnings. so i would NACK this PR as is. This would seem better fitting as a Note about working with wallets / monero-wallet-rpc. The new docs site can facilitate this better i feel.
|
No description provided.