heed NO_COLOR environment variable

[moneromooo-monero]

No description provided.

[SChernykh]

You should use strtol to check the actual numeric value if you want to compare with 0.

[moneromooo-monero]

I don't want to compare with 0, 0 apparently means the same as 1 or yes or no (according to the page). The contents do not matter, only their existence.

[SChernykh]

Yes, I've just read the docs too and it explicitly say "any non-empty string", so it's better to leave the code as is.

[jeffro256]

This works for me! The only xterm control sequences produced with this PR + the env variable are bracketed paste sequences.

[moneromooo-monero]

I had no idea what bracketed paste sequences were. Having looked that up, I have no idea what could be generating those, wikipedia says it's a tty thing. Where do you see those ?

[jeffro256]

I tried looking for what could be generating those sequences as well without luck. The sequence is \e[?2004h, and they seem to be randomly dispersed throughout the output, as you can see on this example monerod stdout before the line "Starting p2p net loop".

2023-01-02 19:00:41.114 I Monero 'Fluorine Fermi' (v0.18.1.0-bfd7c00ce)
2023-01-02 19:00:41.114 I Initializing cryptonote protocol...
2023-01-02 19:00:41.114 I Cryptonote protocol initialized OK
2023-01-02 19:00:41.118 I Initializing core...
2023-01-02 19:00:41.118 I Loading blockchain from folder /home/jeff/.bitmonero/lmdb ...
2023-01-02 19:00:43.386 I Loading checkpoints
2023-01-02 19:00:43.387 I Core initialized OK
2023-01-02 19:00:43.387 I Initializing p2p server...
2023-01-02 19:00:43.397 I p2p server initialized OK
2023-01-02 19:00:43.397 I Initializing core RPC server...
2023-01-02 19:00:43.399 I Binding on 127.0.0.1 (IPv4):18081
2023-01-02 19:00:43.403 I core RPC server initialized OK on port: 18081
2023-01-02 19:00:43.407 I Starting core RPC server...
2023-01-02 19:00:43.408 I core RPC server started ok
ESC[?2004h2023-01-02 19:00:43.408       I Starting p2p net loop...
2023-01-02 19:00:44.409 I 
2023-01-02 19:00:44.409 I **********************************************************************
2023-01-02 19:00:44.409 I The daemon will start synchronizing with the network. This may take a long time to complete.
2023-01-02 19:00:44.409 I 
2023-01-02 19:00:44.409 I You can set the level of process detailization through "set_log <level|categories>" command,
2023-01-02 19:00:44.409 I where <level> is between 0 (no details) and 4 (very verbose), or custom category based levels (eg, *:WARNING).
2023-01-02 19:00:44.409 I 
2023-01-02 19:00:44.409 I Use the "help" command to see the list of available commands.
2023-01-02 19:00:44.409 I Use "help <command>" to see a command's documentation.
2023-01-02 19:00:44.409 I **********************************************************************
2023-01-02 19:00:44.418 W Unable to send transaction(s), no available connections
2023-01-02 19:00:47.996 I Version 0.18.1.2 of monero for source is available: https://downloads.getmonero.org/source/monero-source-v0.18.1.2.tar.bz2, SHA256 hash 0b667acba2223f8f082b388d7ceb5d212e0515b8a94395f3ec69183ef4bebf6c
2023-01-02 19:00:50.187 I [142.132.210.169:18080 OUT] Sync data returned a new top block candidate: 2791013 -> 2791030 [Your node is 17 blocks (34.0 minutes) behind] 
2023-01-02 19:00:50.188 I SYNCHRONIZATION started
2023-01-02 19:01:04.815 I Synced 2791030/2791030
2023-01-02 19:01:04.816 I 
2023-01-02 19:01:04.816 I **********************************************************************
2023-01-02 19:01:04.816 I You are now synchronized with the network. You may now start monero-wallet-cli.
2023-01-02 19:01:04.816 I 
2023-01-02 19:01:04.816 I Use the "help" command to see the list of available commands.
2023-01-02 19:01:04.816 I **********************************************************************

Linux is 5.15.0-56-generic
OS is Ubuntu 22.04.1 LTS

Maybe it's a libreadline thing?

[jeffro256]

Maybe related: pexpect/pexpect#669

[jeffro256]

Could we please get this opened against release?

[SChernykh]

@jeffro256 #9047