Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemonizer: replace boost chrono/thread with std lib #9544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

daemonizer: replace boost chrono/thread with std lib #9544

wants to merge 1 commit into from

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Oct 25, 2024

No description provided.

@vtnerd
Copy link
Contributor

vtnerd commented Oct 25, 2024

Previously we used boost::thread because std::thread had issues with mingw. Is this no longer the case? I think mingw was finally updated?

@tobtoht
Copy link
Contributor Author

tobtoht commented Oct 25, 2024

@vtnerd Ah thanks, I forgot about that. For release builds, mingw hasn't been updated in quite some time. It will get updated to a recent version with #8929, so we can hold off with this until that one is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

Assignees
No one assigned
Labels
easy pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobtoht @vtnerd @0xFFFC0000