PAY-469-updated-types-for-recurring-payments #88
Conversation
src/schema/payment.ts
Outdated
| | "Month" | ||
| | "Half-year" | ||
| | "Year" | ||
| type PeriodType = "Day" | "Week" | "Fortnight" | "Month" | "Half-year" | "Year"; |
There was a problem hiding this comment.
Want to try and make sure your formatter doesn't add semicolons to the end. Its not part of our style. Can see that guide here: https://www.notion.so/moneyhub/Development-process-and-style-guide-081e887009414e88a9fe5e8e3df1bf8a#9febd1cc3e0a4a45ad11c873dd86cc54
There was a problem hiding this comment.
Removed semicolons now, formatter was to blame
There was a problem hiding this comment.
It's all reformatted actually, I reckon format on save with prettier installed globally? If so, I think this might be useful, though not familiar with the setup in this particular repo
| @@ -139,27 +127,31 @@ export interface RecurringPaymentSearchParams extends SearchParams { | |||
| } | |||
|
|
|||
| type RecurringPaymentStatus = | |||
There was a problem hiding this comment.
So i think we only return these statuses: https://openbankinguk.github.io/read-write-api-site3/v3.1.11/resources-and-data-models/vrp/domestic-vrps.html#status
The longer list is if we get the paymentDetails and i am not too sure if we add that to the normal status. I can have a look and return to this comment
There was a problem hiding this comment.
Have used the condensed list for now
Changes: