-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump dev-dependencies #775
feat: bump dev-dependencies #775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you directly also take-up this one.
This might be much more work than you anticipated, because the static analyzers might have quite something to complain. |
That things with that comma added to every argument list, can you disable that? Personally, I do not see why we want that. I makes this PR really hard to check also. |
The rules need to be changed here. But i am not which one to add here. I am not yet sure what exactly does cause the changes for PHPCSFixer to find, all the new violations. |
It is caused by the upgrade of doctrine/coding-standard. To be honest, I have no idea either which config it is. I looked up the docs but I am not sure actually. |
Can you try to exclude |
I think splitting it up to seperate PR's make it easier. After that is done a new PR for the coding standards could be done. |
Ok. Let's do the coding standards upgrade here then. |
Superseded by #785 |
Related to moneyphp/iso-currencies#15