Version 6.0.0 (#28)

* init automatic page reset to false * change log * fix tests
mongerinc · Jun 28, 2018 · e45c718 · e45c718
1 parent 0b99c4f
commit e45c718
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,8 @@
 ## Changelog
 
+### 6.0.0
+- Automatic page reset is now off by default
+
 ### 5.6.2
 - Fixing automatic page reset undoing unlimited for group by, term, and sort
 

diff --git a/src/SearchRequest.php b/src/SearchRequest.php
@@ -73,7 +73,7 @@ class SearchRequest {
 	 *
 	 * @var bool
 	 */
-	protected $pageShouldAutomaticallyReset = true;
+	protected $pageShouldAutomaticallyReset = false;
 
 	/**
 	 * @param  mixed    $json    //null | string

diff --git a/tests/Pagination/PaginationTest.php b/tests/Pagination/PaginationTest.php
@@ -50,9 +50,9 @@ public function integerStrings()
 	/**
 	 * @test
 	 */
-	public function resetsByDefault()
+	public function resetsWhenEnabled()
 	{
-		$request = new SearchRequest;
+		$request = SearchRequest::create()->enableAutomaticPageReset();
 
 		$request->page(5)->where('foo', true);
 		$this->assertEquals(1, $request->getPage());
@@ -70,9 +70,9 @@ public function resetsByDefault()
 	/**
 	 * @test
 	 */
-	public function noResetsWhenDisabled()
+	public function noResetsByDefault()
 	{
-		$request = SearchRequest::create()->disableAutomaticPageReset();
+		$request = SearchRequest::create();
 
 		$request->page(5)->where('foo', true);
 		$this->assertEquals(5, $request->getPage());