-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(EAI-383) Fetch & Refine Top Jira Tickets #539
base: main
Are you sure you want to change the base?
Conversation
deployment: OPENAI_CHAT_COMPLETION_DEPLOYMENT, | ||
}; | ||
|
||
// TODO: Convert this into a .eval file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you do as part of this PR or make a follow up ticket?
if doing follow up, it looks like there's some commented out stuff that could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on this @nlarew?
packages/mongodb-artifact-generator/src/commands/generateJiraPromptResponse.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-artifact-generator/src/commands/generateJiraPromptResponse.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-artifact-generator/src/commands/generateJiraPromptResponse.ts
Show resolved
Hide resolved
packages/mongodb-artifact-generator/src/commands/generateJiraPromptResponse.ts
Outdated
Show resolved
Hide resolved
.option("maxInputLength", { | ||
type: "number", | ||
demandOption: false, | ||
description: | ||
"The maximum number of issues to process in this run. Any additional issues are skipped.", | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this functionality included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely for testing purposes - e.g. run my updated prompt on the first 6 of the top issues list.
packages/mongodb-artifact-generator/src/commands/generateJiraPromptResponse.ts
Show resolved
Hide resolved
[prompt: string, response: string][] | ||
>(); | ||
|
||
const generateResponse = makeGenerateResponse({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this should be evaluated but also for this specific project 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
// // Generate a list of N questions/prompts for each issue | ||
const promptsByIssueKey = new Map<string, string[]>(); | ||
const generatePrompts = makeGeneratePrompts({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think should be evaluated but also 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's some ticket confusion here. looks like you updated the name of an existing ticket plus also created a new one https://jira.mongodb.org/browse/EAI-579 (tho the title on that is wrong i think?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I see the issue - 519 is for this prompt-response project & 579 is for more generic RAG helpers like "summarize this input" (that are currently defined in/only used in the artifact generator)
packages/mongodb-artifact-generator/src/commands/generateJiraPromptResponse.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small things throughout.
also some suggestions for bigger changes that i'm not sure are worth implementing even if more correct/maintainable. all these have 🤷 emojis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. pls see/address few new comments. nothing blocking
Co-authored-by: Ben Perlmutter <[email protected]>
Jira: (EAI-383) Fetch & Refine Top Jira Tickets
Changes
generateJiraPromptResponse
command to the artifact generatorUsage
Example output