DOCSP-27679:Make placeholder text consistent #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Jul 18, 2023
source/faq.txt
Outdated
| @@ -97,7 +97,7 @@ applications: | |||
|
|
|||
| .. code-block:: csharp | |||
|
|
|||
| var client = new MongoClient("<connection string>"); | |||
There was a problem hiding this comment.
S: I think <connection string> is the best placeholder, suggesting that you change the placeholder to this in all locations.
source/fundamentals/logging.txt
Outdated
Comment on lines
65
to
66
| var settings = MongoClientSettings.FromConnectionString("<your | ||
| MongoDB URI>"); |
There was a problem hiding this comment.
I: make sure you revert the line breaks that your formatter creates when it comes to code examples.
Suggested change
| var settings = MongoClientSettings.FromConnectionString("<your | |
| MongoDB URI>"); | |
| var settings = MongoClientSettings.FromConnectionString("<your MongoDB URI>"); |
nickldp
added a commit
that referenced
this pull request
Jul 19, 2023
* DOCSP-27679:Make placeholder text consistent * changing placeholder * fixed line wraps (cherry picked from commit 23d1593)
nickldp
added a commit
that referenced
this pull request
Jul 19, 2023
* DOCSP-27679:Make placeholder text consistent * changing placeholder * fixed line wraps (cherry picked from commit 23d1593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-27679
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/csharp/docsworker-xlarge/DOCSP-27679-consistent-placeholder-text/
Self-Review Checklist