-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-27679:Make placeholder text consistent #108
DOCSP-27679:Make placeholder text consistent #108
Conversation
source/faq.txt
Outdated
@@ -97,7 +97,7 @@ applications: | |||
|
|||
.. code-block:: csharp | |||
|
|||
var client = new MongoClient("<connection string>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: I think <connection string>
is the best placeholder, suggesting that you change the placeholder to this in all locations.
source/fundamentals/logging.txt
Outdated
var settings = MongoClientSettings.FromConnectionString("<your | ||
MongoDB URI>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I: make sure you revert the line breaks that your formatter creates when it comes to code examples.
var settings = MongoClientSettings.FromConnectionString("<your | |
MongoDB URI>"); | |
var settings = MongoClientSettings.FromConnectionString("<your MongoDB URI>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* DOCSP-27679:Make placeholder text consistent * changing placeholder * fixed line wraps (cherry picked from commit 23d1593)
* DOCSP-27679:Make placeholder text consistent * changing placeholder * fixed line wraps (cherry picked from commit 23d1593)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-27679
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/csharp/docsworker-xlarge/DOCSP-27679-consistent-placeholder-text/
Self-Review Checklist