DOCSP-43525 - Decimal128 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
requested changes
Sep 26, 2024
source/upgrade.txt
Outdated
| @@ -102,6 +102,15 @@ Version 3.0 Potential Breaking Change | |||
| - TLS 1.0 and 1.1 are no longer supported. You must use TLS 1.2 or higher. To learn | |||
| more about configuring TLS/SSL in the {+driver-short+}, see :ref:`<csharp-tls>`. | |||
|
|
|||
| - In previous versions of the driver, if a field had the C# data type ``Decimal128`` or | |||
There was a problem hiding this comment.
Suggested change
| - In previous versions of the driver, if a field had the C# data type ``Decimal128`` or | |
| - In previous versions of the driver, if a field had a value of {+language+} data type ``Decimal128`` or |
source/upgrade.txt
Outdated
Comment on lines
105
to
108
| - In previous versions of the driver, if a field had the C# data type ``Decimal128`` or | ||
| ``decimal``, the driver serialized the value as a BSON ``string`` by default. In | ||
| version 3.0, the driver defaults to serializing these values as BSON ``Decimal128`` | ||
| values instead. |
There was a problem hiding this comment.
S: flip these sentence around eg
Serializes {+language+}
Decimal128values as BSONDecimal128values. In prev versions...
source/upgrade.txt
Outdated
Comment on lines
109
to
110
| To serialize a a ``decimal`` or ``Decimal128`` value as a string, | ||
| apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. |
There was a problem hiding this comment.
Suggested change
| To serialize a a ``decimal`` or ``Decimal128`` value as a string, | |
| apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. | |
| To serialize a ``decimal`` or ``Decimal128`` value as a string, | |
| apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. |
source/upgrade.txt
Outdated
Comment on lines
109
to
110
| To serialize a a ``decimal`` or ``Decimal128`` value as a string, | ||
| apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. |
There was a problem hiding this comment.
S: Instead of boradly linking to the serialization guide, consider linking to the bsonrepresentation attribute content
mongoKart
requested review from
a team and
sanych-sun
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43525
Staging Links
Self-Review Checklist