-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-43525 - Decimal128 #240
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small things
source/upgrade.txt
Outdated
@@ -102,6 +102,15 @@ Version 3.0 Potential Breaking Change | |||
- TLS 1.0 and 1.1 are no longer supported. You must use TLS 1.2 or higher. To learn | |||
more about configuring TLS/SSL in the {+driver-short+}, see :ref:`<csharp-tls>`. | |||
|
|||
- In previous versions of the driver, if a field had the C# data type ``Decimal128`` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In previous versions of the driver, if a field had the C# data type ``Decimal128`` or | |
- In previous versions of the driver, if a field had a value of {+language+} data type ``Decimal128`` or |
source/upgrade.txt
Outdated
- In previous versions of the driver, if a field had the C# data type ``Decimal128`` or | ||
``decimal``, the driver serialized the value as a BSON ``string`` by default. In | ||
version 3.0, the driver defaults to serializing these values as BSON ``Decimal128`` | ||
values instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: flip these sentence around eg
Serializes {+language+}
Decimal128
values as BSONDecimal128
values. In prev versions...
source/upgrade.txt
Outdated
To serialize a a ``decimal`` or ``Decimal128`` value as a string, | ||
apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To serialize a a ``decimal`` or ``Decimal128`` value as a string, | |
apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. | |
To serialize a ``decimal`` or ``Decimal128`` value as a string, | |
apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. |
source/upgrade.txt
Outdated
To serialize a a ``decimal`` or ``Decimal128`` value as a string, | ||
apply the ``[BsonRepresentation(BsonType.String)]`` attribute to the field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Instead of boradly linking to the serialization guide, consider linking to the bsonrepresentation attribute content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43525
Staging Links
Self-Review Checklist