DOCSP-43829 - Disposable IMongoClient #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
commented
Sep 26, 2024
| API reference page on MSDN. | ||
| API reference page on MSDN. | ||
|
|
||
| - The ``IMongoClient`` interface inherits the ``IDisposable`` interface. As a result, the |
There was a problem hiding this comment.
Tech reviewer: I don't see this as a breaking change, but correct me if I'm wrong
There was a problem hiding this comment.
Yes, this is not a breaking change.
We should mention that Dispose disposes the underlying cluster and connections to the server.
Also this is an experimental feature, so we should document it as such.
rustagir
approved these changes
Sep 26, 2024
mongoKart
force-pushed
the
docsp-43829-mongoclient-disposable
branch
from
e5aa07e
to
46140bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43829
Staging Links
Self-Review Checklist