Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43829 - Disposable IMongoClient #241

Merged

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Sep 26, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43829

Staging Links

  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Sep 26, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 46140bc
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66fd6d7159d0c20008d6651f
    😎 Deploy Preview https://deploy-preview-241--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    API reference page on MSDN.
    API reference page on MSDN.

    - The ``IMongoClient`` interface inherits the ``IDisposable`` interface. As a result, the
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Tech reviewer: I don't see this as a breaking change, but correct me if I'm wrong

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes, this is not a breaking change.
    We should mention that Dispose disposes the underlying cluster and connections to the server.
    Also this is an experimental feature, so we should document it as such.

    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm with a nit suggestion

    source/whats-new.txt Outdated Show resolved Hide resolved
    Copy link
    Collaborator

    @BorisDog BorisDog left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Left a comment

    @mongoKart mongoKart force-pushed the docsp-43829-mongoclient-disposable branch from e5aa07e to 46140bc Compare October 2, 2024 15:57
    Copy link
    Collaborator

    @BorisDog BorisDog left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mongoKart mongoKart merged commit fcd7fc1 into mongodb:v3.0 Oct 2, 2024
    6 checks passed
    @mongoKart mongoKart deleted the docsp-43829-mongoclient-disposable branch October 2, 2024 18:23
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants