-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-44005 - DateTimeOffset #245
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
source/whats-new.txt
Outdated
API reference page on MSDN. | ||
|
||
- Serializes ``DateTimeOffset`` values as BSON documents, and the | ||
``DateTime`` values in these documents as milliseconds since the Unix epoch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that either we just say that now the default serialization is document, or if we want to go into details we should specify all the document fields:
DateTime
(milliseconds since Unix Epoch)Ticks
(the ticks of the value)Offset
(the total minutes of the value)
I don't have a strong preference for either of those, and if users already know what's inside the document (that has not changed this version), then we can just say we changed the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to the v3 Upgrade page.
source/whats-new.txt
Outdated
driver versions serialized these values as BSON arrays. | ||
|
||
For more information about this release, see the :github:`v3.0 release notes | ||
</mongodb/mongo-csharp-driver/releases/tag/v3.0.0>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link broken until APIs are published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44005
Staging Links
Self-Review Checklist