DOCSP-44005 - DateTimeOffset #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
requested review from
a team and
sanych-sun
and removed request for
a team
papafe
reviewed
Oct 3, 2024
source/whats-new.txt
Outdated
| API reference page on MSDN. | ||
|
|
||
| - Serializes ``DateTimeOffset`` values as BSON documents, and the | ||
| ``DateTime`` values in these documents as milliseconds since the Unix epoch. |
There was a problem hiding this comment.
I would say that either we just say that now the default serialization is document, or if we want to go into details we should specify all the document fields:
DateTime(milliseconds since Unix Epoch)Ticks(the ticks of the value)Offset(the total minutes of the value)
I don't have a strong preference for either of those, and if users already know what's inside the document (that has not changed this version), then we can just say we changed the default
There was a problem hiding this comment.
Should we consider this a breaking change?
There was a problem hiding this comment.
Moved to the v3 Upgrade page.
mongoKart
commented
Oct 3, 2024
source/whats-new.txt
Outdated
| driver versions serialized these values as BSON arrays. | ||
|
|
||
| For more information about this release, see the :github:`v3.0 release notes | ||
| </mongodb/mongo-csharp-driver/releases/tag/v3.0.0>`. |
There was a problem hiding this comment.
Link broken until APIs are published
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44005
Staging Links
Self-Review Checklist