DOCSP-34044: Add bitwise operators to aggregation pipeline #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mayaraman19
commented
Oct 15, 2024
mayaraman19
changed the title
rustagir
requested changes
Oct 15, 2024
rustagir
requested changes
Oct 16, 2024
rustagir
approved these changes
Oct 16, 2024
mayaraman19
requested review from
a team and
sanych-sun
and removed request for
a team
rstam
suggested changes
Oct 22, 2024
| // start-bitAnd-collection-example | ||
|
|
||
| var query = queryableCollection | ||
| .Select(i => i.Price & i.Count); |
There was a problem hiding this comment.
This is an odd example. There's no real reason to bit-and a Price and a Count.
A better example would involve flags or something.
There was a problem hiding this comment.
Changed the example!
source/fundamentals/linq.txt
Outdated
| .. note:: Missing or Undefined Operands | ||
|
|
||
| If the operand list you pass to any bitwise operator contains a missing or | ||
| undefined value, the entire expression evaluates to ``null``. |
There was a problem hiding this comment.
This is true server-side, but in C# this isn't true unless you are using "nullable" integers.
In these examples if either Price or Count is null the query will fail client-side while deserializing the results.
There was a problem hiding this comment.
Clarified the note, please take a look!
|
|
||
| The ``null`` result comes from the document where the ``Name`` field | ||
| has the value of ``"cheese"``. This document is missing a ``Count`` field, so | ||
| the expression evaluates to ``null``. |
There was a problem hiding this comment.
Have you tried to execute this?
I think it will throw an exception because the null can't be deserialized to an int client-side.
There was a problem hiding this comment.
All examples in this PR have been executed - although, the issue is that I was using nullable integers but did not add that in the example. They have now been added.
source/fundamentals/linq.txt
Outdated
| { "_id": 3, "name": "eggs", "price": 5, "count": 12 }, | ||
| { "_id": 4, "name": "potatoes", "price": 3, "count": 0 }, | ||
| { "_id": 5, "name": "pasta", "price": 4, "count": 100 }, | ||
| { "_id": 6, "name": "cheese", "price": 4 } |
There was a problem hiding this comment.
This final document can't have been created using the Ingredient POCO because Count is an int and can't be null.
Also, the element names in these sample documents don't match the field names in the POCO (the C# properties start with a capital letter).
There was a problem hiding this comment.
The data types used in the example have been changed to be nullable.
As for the second point, for these examples we use a convention pack (see the bottom of the Overview section on this page) to convert snake case field names into Pascal case.
There was a problem hiding this comment.
It's hard to tell from looking at just this PR that there is a convention somewhere else that is mapping the property names. That's confusing.
| -13 | ||
| -5 | ||
| -101 | ||
| null |
There was a problem hiding this comment.
null is not a possible result. It should throw an exception when deserializing the results.
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
mayaraman19
added a commit
that referenced
this pull request
Oct 24, 2024
* changing code + checkpint * very preliminary first draft * correct code block * code blocks * and and or * xor, not, and other small tweaks * changing variable type in linq.cs * never mind * back to double * addressing basic comments * move code to include * io code block * reworking first sentence * bullet list * bullet list pt 2 * bullet list pt 3 * feedback * nits * change example * correction * snake case * refining note * vale (cherry picked from commit a1b1f4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34044
Staging Links
Self-Review Checklist