Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-44476 - BsonValue methods #256

Merged
merged 3 commits into from
Oct 18, 2024
Merged

DOCSP-44476 - BsonValue methods #256

merged 3 commits into from
Oct 18, 2024

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Oct 16, 2024 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44476

Staging Links

  • upgrade/v3

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Oct 16, 2024 •
    edited
    Loading

    ✅ Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 048c98c
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/67127db1991e4a0008994a2c
    😎 Deploy Preview https://deploy-preview-256--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    norareidy
    norareidy approved these changes Oct 16, 2024
    View reviewed changes
    Copy link
    Collaborator

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mongoKart mongoKart requested a review from papafe October 16, 2024 20:22
    papafe
    papafe suggested changes Oct 18, 2024
    View reviewed changes
    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    All the As... elements are properties, not methods. So we need to write that they are properties and remove the parenthesis

    @mongoKart
    Copy link
    Collaborator Author

    All the As... elements are properties, not methods. So we need to write that they are properties and remove the parenthesis

    Didn't realize. Thanks!

    @mongoKart mongoKart requested a review from papafe October 18, 2024 15:24
    papafe
    papafe approved these changes Oct 18, 2024
    View reviewed changes
    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good!

    @mongoKart mongoKart merged commit dd333de into mongodb:master Oct 18, 2024
    6 checks passed
    @mongoKart mongoKart deleted the docsp-44476-remove-methods branch October 18, 2024 17:23
    mongoKart added a commit that referenced this pull request Oct 18, 2024
    @mongoKart
    DOCSP-44476 - BsonValue properties (#256)
    9ec74f8 
    (cherry picked from commit dd333de)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @papafe papafe papafe approved these changes

    @norareidy norareidy norareidy approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mongoKart @papafe @norareidy