Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action security updates #264

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Oct 17, 2024

Pull Request Info

PR Reviewing Guidelines

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for mongodb-docs-csharp ready!

Name Link
🔨 Latest commit 05136f1
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/67129bd3347e0b0008eac0ac
😎 Deploy Preview https://deploy-preview-264--mongodb-docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

regexFlags: is
content: "<!-- start insert-links -->\n${{ steps.build_page_links.outputs.staging_links }}\n<!-- end insert-links -->"
token: ${{ secrets.GITHUB_TOKEN }}
get-pr-changes:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all these lines are changed; VS Code changed the indenting. Changes are between lines 18 and 48

Copy link
Collaborator

@MongoCaleb MongoCaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm seeing this correctly, the two main changes are 1) adding the env rather than using a local variable, and 2) adding a validation function. If there are others that I didn't comment on, please let me know!

.github/workflows/add-netlify-links.yml Show resolved Hide resolved
.github/workflows/add-netlify-links.yml Outdated Show resolved Hide resolved
echo "processing ${file}"

# Validate file path and skip if invalid
validate_file_path "$file"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related to my comment above.

.github/workflows/add-netlify-links.yml Show resolved Hide resolved
Copy link
Collaborator

@MongoCaleb MongoCaleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart merged commit 02a6875 into mongodb:master Oct 18, 2024
4 of 5 checks passed
@mongoKart mongoKart deleted the secbug-304-rce branch October 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants