Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-28748: bson-kotlin dependency #147

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-28748
Staging

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one typo fix and a suggestion

see the :ref:`Codecs <fundamentals-codecs>` documentation. You might choose
Kotlin serialization if you are already familiar with the framework or
you prefer to use an idiomatic Kotlin approach.
To learn about how to use the ``Codec`` interface instead of the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To learn about how to use the ``Codec`` interface instead of the
To learn how to use the ``Codec`` interface instead of the

and the codec registry to support Kotlin data classes, but it does
not support certain POJO annotations such as ``BsonDiscriminator``,
``BsonExtraElements``, and ``BsonConstructor``. To learn more, see
the `bson-kotlin API documentation <{+api+}/apidocs/bson-kotlin/index.html>`__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the `bson-kotlin API documentation <{+api+}/apidocs/bson-kotlin/index.html>`__
the `bson-kotlin API documentation <{+api+}/apidocs/bson-kotlin/index.html>`__.

@rustagir rustagir merged commit a5cbf35 into mongodb:master Jan 23, 2024
4 checks passed
rustagir added a commit that referenced this pull request Jan 23, 2024
* fix link

* fix link

* DOCSP-28748: bson-kotlin note

* vale fix

* JS PR fix

(cherry picked from commit a5cbf35)
rustagir added a commit that referenced this pull request Jan 23, 2024
* fix link

* fix link

* DOCSP-28748: bson-kotlin note

* vale fix

* JS PR fix

(cherry picked from commit a5cbf35)
@docs-builder-bot
Copy link
Collaborator

ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Feb 14, 2024
* fix link

* fix link

* DOCSP-28748: bson-kotlin note

* vale fix

* JS PR fix
ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Feb 14, 2024
* fix link

* fix link

* DOCSP-28748: bson-kotlin note

* vale fix

* JS PR fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants