Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-35884: custom serializer example #148

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Jan 30, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35884
Staging

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice job!

@@ -22,7 +22,7 @@ driver-long = "MongoDB Kotlin Driver"
version = "4.11"
full-version = "{+version+}.0"
mdb-server = "MongoDB server"
kotlin-docs = "https://kotlinlang.org/docs"
kotlin-docs = "https://kotlinlang.org"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious about the reason for this change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it is usable for links that are at https://kotlinlang.org/docs and https://kotlinlang.org/api/, seemed silly to use the source constant for some links at the same site but not others

@rustagir rustagir requested a review from rozza January 30, 2024 17:08
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@rustagir rustagir merged commit 5015f98 into mongodb:master Feb 5, 2024
5 checks passed
rustagir added a commit that referenced this pull request Feb 5, 2024
* DOCSP-35884: custom serializer example

* rearrange structure

* add intro to dependency tabs

* small fix

(cherry picked from commit 5015f98)
rustagir added a commit that referenced this pull request Feb 5, 2024
* DOCSP-35884: custom serializer example

* rearrange structure

* add intro to dependency tabs

* small fix

(cherry picked from commit 5015f98)
@docs-builder-bot
Copy link
Collaborator

ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Feb 14, 2024
* DOCSP-35884: custom serializer example

* rearrange structure

* add intro to dependency tabs

* small fix
ccho-mongodb pushed a commit to ccho-mongodb/docs-kotlin that referenced this pull request Feb 14, 2024
* DOCSP-35884: custom serializer example

* rearrange structure

* add intro to dependency tabs

* small fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants