-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-35884: custom serializer example #148
DOCSP-35884: custom serializer example #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. nice job!
@@ -22,7 +22,7 @@ driver-long = "MongoDB Kotlin Driver" | |||
version = "4.11" | |||
full-version = "{+version+}.0" | |||
mdb-server = "MongoDB server" | |||
kotlin-docs = "https://kotlinlang.org/docs" | |||
kotlin-docs = "https://kotlinlang.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious about the reason for this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that it is usable for links that are at https://kotlinlang.org/docs
and https://kotlinlang.org/api/
, seemed silly to use the source constant for some links at the same site but not others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
* DOCSP-35884: custom serializer example * rearrange structure * add intro to dependency tabs * small fix (cherry picked from commit 5015f98)
* DOCSP-35884: custom serializer example * rearrange structure * add intro to dependency tabs * small fix (cherry picked from commit 5015f98)
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/kotlin/master/ 🪵 Logs |
* DOCSP-35884: custom serializer example * rearrange structure * add intro to dependency tabs * small fix
* DOCSP-35884: custom serializer example * rearrange structure * add intro to dependency tabs * small fix
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-35884
Staging
Self-Review Checklist