Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43826: v5.2 release #175

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Sep 25, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43826
Staging: compat, quickstart

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for docs-kotlin ready!

Name Link
🔨 Latest commit 15cd536
🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin/deploys/66f48005809e890008869eef
😎 Deploy Preview https://deploy-preview-175--docs-kotlin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ 2 notes

@@ -270,6 +270,11 @@ The following code example shows how to create an Atlas Search index:
.. literalinclude:: /examples/generated/SearchIndexesTest.snippet.single-search-index-create.kt
:language: kotlin

To create multiple Search or Vector Search indexes, you must create a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Confirming that these should be capitalized

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this PR, but you can also remove MongoDB columns for v3.4 and earlier

@rustagir rustagir merged commit 2e93b14 into mongodb:master Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants