DOCSP-37612: v6.5.0 release #881
Conversation
source/whats-new.txt
Outdated
| - Moved ``ObjectId`` generation to the ``pkFactory`` class for bulk write | ||
| operations. |
There was a problem hiding this comment.
S: match tense
| - Moved ``ObjectId`` generation to the ``pkFactory`` class for bulk write | |
| operations. | |
| - Moves ``ObjectId`` generation to the ``pkFactory`` class for bulk write | |
| operations. |
source/whats-new.txt
Outdated
| If you previously specified the ``pkFactory`` to handle bulk writes, | ||
| the ``_id`` fields of the documents inserted by using bulk writes may | ||
| be inconsistent with the behavior in this version. |
There was a problem hiding this comment.
| If you previously specified the ``pkFactory`` to handle bulk writes, | |
| the ``_id`` fields of the documents inserted by using bulk writes may | |
| be inconsistent with the behavior in this version. | |
| If you previously specified that a ``pkFactory`` instance handles bulk writes, | |
| the ``_id`` fields of the documents inserted by using bulk writes may | |
| be inconsistent with the behavior in this version. |
There was a problem hiding this comment.
Good call! Will update to clarify an instance.
| - Moved ``ObjectId`` generation to the ``pkFactory`` class for bulk write | ||
| operations. | ||
|
|
||
| .. warning:: |
There was a problem hiding this comment.
Q: should this warning be indented to be under the preceding bullet point?
There was a problem hiding this comment.
I'm not sure you can put an admonition in a list, but I'll try it out.
There was a problem hiding this comment.
Unfortunately, that didn't work (unexpected indentation error)
source/whats-new.txt
Outdated
| - Fixes the read preference sent with read operations when directly connected | ||
| to a secondary in the replica set to ``primaryPreferred``. |
There was a problem hiding this comment.
| - Fixes the read preference sent with read operations when directly connected | |
| to a secondary in the replica set to ``primaryPreferred``. | |
| - Sets the read preference that is sent with read operations to ``primaryPreferred`` when | |
| you are directly connected to a secondary in the replica set. |
There was a problem hiding this comment.
Thanks for the rewording. I'll use parts of this suggestion, but will continue to use the verb "fixes" to make sure it's understood that way. From the release notes:
Fixed applying read preference to commands depending on topology
| To learn more about this release, see the | ||
| `v6.5.0 Release Highlights | ||
| <https://github.com/mongodb/node-mongodb-native/releases/tag/v6.5.0>`__ on | ||
| GitHub. |
There was a problem hiding this comment.
S: maybe out of scope, but I noticed the v6.4 section is missing this link
There was a problem hiding this comment.
Good catch, I'll add it.
source/whats-new.txt
Outdated
| - Moves ``ObjectId`` generation to the ``pkFactory`` class for bulk write | ||
| operations. |
There was a problem hiding this comment.
| - Moves ``ObjectId`` generation to the ``pkFactory`` class for bulk write | |
| operations. | |
| - Bulk write operations generate document ids using the ``pkFactory`` |
There was a problem hiding this comment.
Thanks, I'll change "ObjectID generation" to "generate document ids".
To maintain the style, the bullet point needs to start with a present tense verb. I'll change it to the following (feel free to suggest something else):
"Updates bulk write operations to use the pkFactory class for document id generation."
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-37612
Staging:
Self-Review Checklist