Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-32561: Exact versions in upgrade guide #887

Merged
merged 3 commits into from
May 7, 2024

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented May 7, 2024

Pull Request Info

PR Reviewing Guidelines

Note: all breaking changes were introduced in major versions, so ".x" has been changed to ".0".

JIRA - https://jira.mongodb.org/browse/DOCSP-32561
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/node/DOCSP-32561-exact-versions/upgrade/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a suggestion

.. _node-breaking-changes-v6.x:
.. _node-breaking-changes-v6.0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: instead of replacing the anchor, add a new one underneath the old one so that we dont potentially break any links. Applies to all sections!

@norareidy norareidy merged commit 6d2df34 into mongodb:master May 7, 2024
2 checks passed
@norareidy norareidy deleted the DOCSP-32561-exact-versions branch May 7, 2024 17:13
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
(cherry picked from commit a632359)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
(cherry picked from commit a632359)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
(cherry picked from commit a632359)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
(cherry picked from commit a632359)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
(cherry picked from commit a632359)
(cherry picked from commit 9b035b7)
norareidy added a commit that referenced this pull request May 7, 2024
* DOCSP-32561: Exact versions in upgrade guide

* fix

* RR feedback

(cherry picked from commit 6d2df34)
(cherry picked from commit f36bcf0)
(cherry picked from commit a632359)
(cherry picked from commit 9b035b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants