(DOCSP-17079): Mac Catalyst Support - React Native #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadhunan-dev
changed the title
takameyer
reviewed
Jul 27, 2021
| @@ -0,0 +1,63 @@ | |||
| title: Update Your Build Phase Settings | |||
There was a problem hiding this comment.
Just want to make clear, this step should go away in the next React Native release. Here is the relevant PR facebook/react-native#31062
There was a problem hiding this comment.
So maybe we could already cover our bases by saying do this step for RN < v0.65
There was a problem hiding this comment.
Thanks 👍 added some text in a few spots saying that this is for RN v 0.64 and below, and that you don't need it for RN v 0.65 and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Jira
Staged Changes (Requires MongoDB Corp SSO)
Review Guidelines
REVIEWING.md