fix(NODE-5577): improve ObjectId serialization by around 10% #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
|
Hi @billouboq thanks for this PR. We'll be accepting this change, but will have to make some changes to your benchmarks to work with our new benchmark infrastructure. |
|
@W-A-James nice, perfect ! 👍 |
|
Link with successful evergreen run (pinned npm version) |
baileympearson
added
the
Primary Review
baileympearson
approved these changes
Sep 8, 2023
baileympearson
added
Team Review
baileympearson
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving ObjectId Serialisation by 10% and add an ObjectId serialisation benchmark
What is changing?
Remove buffer.set and subarray call and use a basic for loop