Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-6401): migrate node download script to drivers-tools #718

Merged
merged 6 commits into from
Oct 15, 2024
Merged

chore(NODE-6401): migrate node download script to drivers-tools #718

merged 6 commits into from
Oct 15, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Migrate to shared drivers script for node download, mainly to get retry on curl failure
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Remove flaky curl failure

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title chore(NODE-5845): migrate node download script to drivers-tools chore(NODE-6401): migrate node download script to drivers-tools Sep 27, 2024
@dariakp dariakp marked this pull request as draft September 27, 2024 15:51
@nbbeeken
Copy link
Contributor Author

🎉 : https://parsley.mongodb.com/evergreen/node_bson_linux_node_tests_v16_patch_064ba916e5d64aa59a2bce165553e40892687ab4_66f6f78276c798000725bba7_24_09_27_18_20_50/0/task?bookmarks=0,7086&shareLine=61

@nbbeeken nbbeeken marked this pull request as ready for review September 27, 2024 18:34
@durran durran self-assigned this Oct 15, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 15, 2024
@durran durran merged commit c08fa56 into main Oct 15, 2024
8 checks passed
@durran durran deleted the chore-node-5845 branch October 15, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran