-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-4619: Add axes components #2525
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7de6114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +920 B (+0.07%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
84f54f4
to
364ccaa
Compare
export function updateOptions( | ||
currentOptions: ChartOptions, | ||
options: Partial<ChartOptions>, | ||
): Partial<ChartOptions> { | ||
return merge({ ...currentOptions, ...options }); | ||
return recursiveMerge(currentOptions, options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why we're replacing the lodash merge, but that's a question not a blocker
✍️ Proposed changes
XAxis
component for adding an x-axis to a chart.YAxis
component for adding a y-axis to a chart.lodash.merge
was being used originally, but this didn't work quite as expected. The goal is to merge partial options objects in without overwriting previously set options that are unrelated to the update. This was not how it worked, leading to bugs when updating the same base keys with different options. I.e. when addingsplitLine
configurations onxAxis
in order to add grid lines, then adding more axis specific config inXAxis
related to the actual axis, thesplitLine
would be totally overwritten.@lg-charts/core
Storybook, by adding better descriptions and organization.🎟 Jira ticket: LG-4619: Add axes components
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changesFor new components
🧪 How to test changes