LG-4619: Add axes components #2525
Open
+487
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7de6114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +920 B (+0.07%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
tsck
force-pushed
the
LG-4619/axis-components
branch
from
84f54f4
to
364ccaa
Compare
bruugey
reviewed
Oct 30, 2024
| export function updateOptions( | ||
| currentOptions: ChartOptions, | ||
| options: Partial<ChartOptions>, | ||
| ): Partial<ChartOptions> { | ||
| return merge({ ...currentOptions, ...options }); | ||
| return recursiveMerge(currentOptions, options); |
There was a problem hiding this comment.
Curious why we're replacing the lodash merge, but that's a question not a blocker
bruugey
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
XAxiscomponent for adding an x-axis to a chart.YAxiscomponent for adding a y-axis to a chart.lodash.mergewas being used originally, but this didn't work quite as expected. The goal is to merge partial options objects in without overwriting previously set options that are unrelated to the update. This was not how it worked, leading to bugs when updating the same base keys with different options. I.e. when addingsplitLineconfigurations onxAxisin order to add grid lines, then adding more axis specific config inXAxisrelated to the actual axis, thesplitLinewould be totally overwritten.@lg-charts/coreStorybook, by adding better descriptions and organization.🎟 Jira ticket: LG-4619: Add axes components
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes