test(NODE-4556): address comments

mongodb · Aug 19, 2022 · 65dc4e1 · 65dc4e1
1 parent 45e6ba7
commit 65dc4e1
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/bindings/node/test/autoEncrypter.test.js b/bindings/node/test/autoEncrypter.test.js
@@ -111,8 +111,7 @@ describe('AutoEncrypter', function () {
   });
 
   describe('#constructor', function () {
-    // This case is driver 4.9.0 and higher.
-    context('when mongodb exports BSON', function () {
+    context('when mongodb exports BSON (driver >= 4.9.0)', function () {
       context('when a bson option is provided', function () {
         const bson = Object.assign({}, BSON);
         const encrypter = new AutoEncrypter(
@@ -144,10 +143,13 @@ describe('AutoEncrypter', function () {
           expect(encrypter._bson).to.equal(BSON);
         });
       });
+
+      it('never uses bson from the topology', function () {
+        expect(() => new AutoEncrypter({}, {})).not.to.throw();
+      });
     });
 
-    // This case is driver < 4.9.0.
-    context('when mongodb does not export BSON', function () {
+    context('when mongodb does not export BSON (driver < 4.9.0)', function () {
       context('when a bson option is provided', function () {
         const bson = Object.assign({}, BSON);
         const encrypter = new AutoEncrypter(

diff --git a/bindings/node/test/clientEncryption.test.js b/bindings/node/test/clientEncryption.test.js
@@ -63,8 +63,7 @@ describe('ClientEncryption', function () {
   }
 
   describe('#constructor', function () {
-    // This case is driver 4.9.0 and higher.
-    context('when mongodb exports BSON', function () {
+    context('when mongodb exports BSON (driver >= 4.9.0)', function () {
       context('when a bson option is provided', function () {
         const bson = Object.assign({}, BSON);
         const encrypter = new ClientEncryption(
@@ -98,10 +97,23 @@ describe('ClientEncryption', function () {
           expect(encrypter._bson).to.equal(BSON);
         });
       });
+
+      it('never uses bson from the topology', function () {
+        expect(() => {
+          new ClientEncryption(
+            {},
+            {
+              keyVaultNamespace: 'client.encryption',
+              kmsProviders: {
+                local: { key: Buffer.alloc(96) }
+              }
+            }
+          )
+        }).not.to.throw();
+      });
     });
 
-    // This case is driver < 4.9.0.
-    context('when mongodb does not export BSON', function () {
+    context('when mongodb does not export BSON (driver < 4.9.0)', function () {
       context('when a bson option is provided', function () {
         const bson = Object.assign({}, BSON);
         const encrypter = new ClientEncryption(