MONGOCRYPT-463 check the collMod command for validator.$jsonSchema
#441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
collMod command for validator.$jsonSchema
vector-of-bool
approved these changes
Aug 12, 2022
src/mongocrypt-ctx-encrypt.c
Outdated
| @@ -1946,19 +1947,23 @@ _try_empty_schema_for_create (mongocrypt_ctx_t *ctx) | |||
| * } | |||
| * } | |||
| * If the "create" command does not include a JSON schema, an empty JSON schema | |||
| * is returned. This is to avoid an unnecessary 'listCollections' command for | |||
| * create. */ | |||
| * is later. This is to avoid an unnecessary 'listCollections' command for | |||
eramongodb
approved these changes
Aug 12, 2022
src/mongocrypt-ctx-encrypt.c
Outdated
| * create. | ||
| * | ||
| * If the "collMod" command does not include a JSON schema, a schema is later | ||
| * requested from other sources. This is because a "collMod" command may have |
There was a problem hiding this comment.
Can "from other sources" be made more specific, e.g. mention the MONGOCRYPT_CTX_NEED_MONGO_COLLINFO state?
…create_or_collMod_cmd
kevinAlbs
added a commit
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
collModcommand forvalidator.$jsonSchemaand send it to query analysis.Background & Motivation
Checking collMod for
validator.$jsonSchemaSince MONGOCRYPT-429, automatic encryption has supported the
collModcommand. Prior to MONGOCRYPT-429, it was always an error to automatically encrypt acollModcommand. AcollModcommand is not bypassed because it may include sensitive plaintext in avalidatorfield:{ "collMod": "encryptedCollection", "validator": { "encryptedField": "plaintext", } }A
collModcommand may also include avalidator.$jsonSchema:{ "collMod": "encryptedCollection", "validator": { "$jsonSchema": { "encryptedField": { "encrypt": { "bsonType": "string", "algorithm": "AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic", "keyId": { "$binary": { "base64": "AAAAAAAAAAAAAAAAAAAAAA==", "subType": "04" } } } } } } }If a
collModincludes avalidator.$jsonSchema, Query Analysis (mongocryptd or the mongo_crypt shared library) expects thejsonSchemafield added by libmongocrypt to match. See MONGOCRYPT-463 for an example of this error.A regression specification test is tested with the Go driver here